Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder in login form for realms #1570

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Apr 13, 2019

Closes #1498

@cornelinux cornelinux requested a review from privacyidea/core Apr 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

Merging #1570 into branch-3.0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1570      +/-   ##
==============================================
- Coverage       96.94%   96.94%   -0.01%     
==============================================
  Files             148      148              
  Lines           17687    17685       -2     
==============================================
- Hits            17147    17145       -2     
  Misses            540      540
Impacted Files Coverage Δ
privacyidea/webui/login.py 90.32% <ø> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e43b23...be94ff9. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

Merging #1570 into branch-3.0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1570      +/-   ##
==============================================
- Coverage       96.94%   96.94%   -0.01%     
==============================================
  Files             148      148              
  Lines           17687    17685       -2     
==============================================
- Hits            17147    17145       -2     
  Misses            540      540
Impacted Files Coverage Δ
privacyidea/webui/login.py 90.32% <ø> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e43b23...be94ff9. Read the comment docs.

@plettich
Copy link
Member

left a comment

looks good

@plettich plettich merged commit c8bd76f into branch-3.0 Apr 16, 2019

4 of 5 checks passed

codecov/project 96.94% (-0.01%) compared to 5e43b23
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5e43b23...be94ff9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1498/realmdropdown branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.