Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolver in UI-user-policies #1577

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Apr 16, 2019

Closes #1496

@cornelinux cornelinux requested a review from privacyidea/core Apr 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #1577 into branch-3.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1577      +/-   ##
==============================================
+ Coverage       96.94%   96.97%   +0.02%     
==============================================
  Files             148      148              
  Lines           17694    17879     +185     
==============================================
+ Hits            17154    17338     +184     
- Misses            540      541       +1
Impacted Files Coverage Δ
privacyidea/lib/policy.py 99.2% <100%> (ø) ⬆️
privacyidea/lib/tokenclass.py 98.87% <0%> (+0.09%) ⬆️
privacyidea/lib/token.py 96.09% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bff3a1...0af9c4a. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #1577 into branch-3.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1577      +/-   ##
==============================================
+ Coverage       96.94%   96.97%   +0.02%     
==============================================
  Files             148      148              
  Lines           17694    17879     +185     
==============================================
+ Hits            17154    17338     +184     
- Misses            540      541       +1
Impacted Files Coverage Δ
privacyidea/lib/policy.py 99.2% <100%> (ø) ⬆️
privacyidea/lib/tokenclass.py 98.87% <0%> (+0.09%) ⬆️
privacyidea/lib/token.py 96.09% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bff3a1...0af9c4a. Read the comment docs.

@cornelinux cornelinux requested a review from fredreichbier Apr 30, 2019

@fredreichbier fredreichbier merged commit 32b1020 into branch-3.0 May 2, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.94%)
Details
codecov/project 96.97% (+0.02%) compared to 6bff3a1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1496/ui-rights-from-resolver branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.