Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the logo to vertical center #1581

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Apr 17, 2019

The logo is contained in the height of the text of the navbar.
Due to this I can not scale the logo larger than the text of
the menu.
This is why the logo was a bit below the center in the first place.

Working on #1559

image

Set the logo to vertical center
The logo is contained in the height of the text of the navbar.
Due to this I can not scale the logo larger than the text of
the menu.
This is why the logo was a bit below the center in the first place.

Working on #1559

@cornelinux cornelinux requested a review from privacyidea/core Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #1581 into branch-3.0 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1581      +/-   ##
==============================================
+ Coverage       96.94%   96.96%   +0.01%     
==============================================
  Files             148      148              
  Lines           17692    17732      +40     
==============================================
+ Hits            17152    17193      +41     
+ Misses            540      539       -1
Impacted Files Coverage Δ
privacyidea/lib/tokens/pushtoken.py 98.08% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd76f...8362c66. Read the comment docs.

Changing padding to make logo larger
If we change the padding in this way, the distance to the border above
and below the logo is smaller, so the logo will be larger and still
centered.
@Mipronimo

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@cornelinux in 8362c66 I changed the padding for the logo.
The logo will be larger.
image

@cornelinux

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

Nice. Would you be willing to merge my changes with your adoptions?

@cornelinux cornelinux requested review from Mipronimo and removed request for privacyidea/core Apr 30, 2019

@Mipronimo Mipronimo merged commit f087f54 into branch-3.0 Apr 30, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c8bd76f...8362c66
Details
codecov/project 96.96% (+0.01%) compared to c8bd76f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the 1559/vertical-center-logo branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.