Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center the dropdown menu on the right #1582

Merged
merged 2 commits into from May 4, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Apr 17, 2019

image

Closes #1559

@cornelinux cornelinux requested a review from privacyidea/core Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #1582 into branch-3.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           branch-3.0    #1582   +/-   ##
===========================================
  Coverage       96.94%   96.94%           
===========================================
  Files             148      148           
  Lines           17692    17692           
===========================================
  Hits            17152    17152           
  Misses            540      540

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd76f...da8ab1e. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #1582 into branch-3.0 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1582      +/-   ##
==============================================
+ Coverage       96.94%   96.98%   +0.03%     
==============================================
  Files             148      148              
  Lines           17692    17841     +149     
==============================================
+ Hits            17152    17303     +151     
+ Misses            540      538       -2
Impacted Files Coverage Δ
privacyidea/lib/usercache.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/pushtoken.py 97.45% <0%> (+0.16%) ⬆️
privacyidea/lib/policy.py 99.82% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd76f...71f6141. Read the comment docs.

@cornelinux cornelinux requested a review from plettich May 2, 2019

Move dropdown to it's own CSS file
Use navbar instead of own class

Closes #1559
@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #1582 into branch-3.0 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1582      +/-   ##
==============================================
+ Coverage       96.94%   96.98%   +0.03%     
==============================================
  Files             148      148              
  Lines           17692    17841     +149     
==============================================
+ Hits            17152    17303     +151     
+ Misses            540      538       -2
Impacted Files Coverage Δ
privacyidea/lib/usercache.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/pushtoken.py 97.45% <0%> (+0.16%) ⬆️
privacyidea/lib/policy.py 99.82% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd76f...71f6141. Read the comment docs.

@cornelinux cornelinux merged commit acb303f into branch-3.0 May 4, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c8bd76f...71f6141
Details
codecov/project 96.98% (+0.03%) compared to c8bd76f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.