Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving the answered challenge. #1585

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented Apr 17, 2019

Fixes #1584

@cornelinux cornelinux requested a review from privacyidea/core Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #1585 into branch-3.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1585      +/-   ##
==============================================
+ Coverage       96.94%   96.94%   +<.01%     
==============================================
  Files             148      148              
  Lines           17692    17696       +4     
==============================================
+ Hits            17152    17156       +4     
  Misses            540      540
Impacted Files Coverage Δ
privacyidea/lib/tokens/pushtoken.py 97.33% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd76f...b42dec0. Read the comment docs.

@plettich
Copy link
Member

left a comment

Looks good.

@plettich plettich merged commit 85b6859 into branch-3.0 Apr 23, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.94%)
Details
codecov/project 96.94% (+<.01%) compared to c8bd76f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1584/save_answered_challenge branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.