Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 rendering issue with 3.0 #1588

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@droobah
Copy link
Contributor

commented Apr 23, 2019

IE11 is still used in many corporate environments and does not render the WebUI due to an unsupported for..of loop. Replaced for..of loop with simple iterative loop.

- fixed rendering issue with ie11
* ie11 does not support for..of loops
@codecov

This comment has been minimized.

Copy link

commented Apr 23, 2019

Codecov Report

Merging #1588 into branch-3.0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1588      +/-   ##
==============================================
- Coverage       96.94%   96.94%   -0.01%     
==============================================
  Files             148      148              
  Lines           17696    17687       -9     
==============================================
- Hits            17156    17147       -9     
  Misses            540      540
Impacted Files Coverage Δ
privacyidea/lib/tokens/pushtoken.py 97.28% <0%> (-0.05%) ⬇️
privacyidea/lib/token.py 95.87% <0%> (-0.02%) ⬇️
privacyidea/lib/tokenclass.py 98.77% <0%> (-0.01%) ⬇️
privacyidea/webui/login.py 90.62% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b6859...6748542. Read the comment docs.

@droobah droobah changed the base branch from master to branch-3.0 Apr 23, 2019

@plettich

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

If IE11 doesn't support u2f anyway, can't we just exclude the complete file if the user-agent is =<IE11?

@droobah

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

If IE11 doesn't support u2f anyway, can't we just exclude the complete file if the user-agent is =<IE11?

I tried renaming the file to simulate this, but the U2F factory is referenced in other scripts so the page still fails to load.

@cornelinux

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@Mipronimo Can you please check this change?
And can you please also check, if we need to adapt this in other plugins?

@Mipronimo Mipronimo merged commit 785442f into privacyidea:branch-3.0 May 6, 2019

2 of 3 checks passed

codecov/project 96.94% (-0.01%) compared to 85b6859
Details
codecov/patch Coverage not affected when comparing 85b6859...6748542
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.