Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical spinner position #1630

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
2 participants
@plettich
Copy link
Member

commented May 14, 2019

The spinner wasn't vertically aligned in the center.
The style of the element needed to be removed from the controller in order
to customize the style through css.

Fixes #1629

Fix vertical spinner position
The spinner wasn't vertically aligned in the center.
The style of the element needed to be removed from the controller in order
to customize the style through css.

@plettich plettich added the Topic:UI label May 14, 2019

@plettich plettich requested a review from privacyidea/core May 14, 2019

@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #1630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         148      148           
  Lines       17738    17738           
=======================================
  Hits        17196    17196           
  Misses        542      542

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01b573...7789a42. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #1630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         148      148           
  Lines       17738    17738           
=======================================
  Hits        17196    17196           
  Misses        542      542

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01b573...7789a42. Read the comment docs.

@cornelinux cornelinux merged commit 7a8b951 into master May 14, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d01b573...7789a42
Details
codecov/project 96.94% remains the same compared to d01b573
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the fix_spinner_position branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.