Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit from remote user fetching #1633

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented May 15, 2019

Fetching the remote user config also occurs by simply
calling the login dialog. At this point, we do not have
an audit object. The pure calling of the login dialog
also does not create any audit entry, so we do not
pass the audit_object.

fixes #1632

Remove audit from remote user fetching
Fetching the remote user config also occurs by simply
calling the login dialog. At this point, we do not have
an audit object. The pure calling of the login dialog
also does not create any audit entry, so we do not
pass the audit_object.

fixes #1632

@cornelinux cornelinux requested a review from plettich May 15, 2019

@codecov

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #1633 into branch-3.0 will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-3.0    #1633      +/-   ##
==============================================
- Coverage       96.98%   96.93%   -0.05%     
==============================================
  Files             148      148              
  Lines           17842    17734     -108     
==============================================
- Hits            17304    17191     -113     
- Misses            538      543       +5
Impacted Files Coverage Δ
privacyidea/api/lib/prepolicy.py 97.03% <66.66%> (-0.17%) ⬇️
privacyidea/lib/eventhandler/base.py 95.96% <0%> (-2.69%) ⬇️
privacyidea/api/auth.py 95.53% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656fe46...0cbab21. Read the comment docs.

@cornelinux cornelinux requested a review from fredreichbier May 15, 2019

Allow to write policy to audit entry
In case of POST /auth the webui Remote user
policy should be written to the audit entry.

Closes #1632
@fredreichbier
Copy link
Member

left a comment

looks good, will merge when travis is happy!

@fredreichbier fredreichbier merged commit 9b0054c into branch-3.0 May 16, 2019

3 of 5 checks passed

codecov/patch 66.66% of diff hit (target 96.98%)
Details
codecov/project 96.93% (-0.05%) compared to 656fe46
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1632/remote-user-audit branch May 16, 2019

@cornelinux cornelinux requested a review from fredreichbier May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.