Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge current branch-3.0 into master #1634

Merged
merged 3 commits into from May 18, 2019

Conversation

Projects
None yet
2 participants
@fredreichbier
Copy link
Member

commented May 16, 2019

No description provided.

cornelinux and others added some commits May 15, 2019

Remove audit from remote user fetching
Fetching the remote user config also occurs by simply
calling the login dialog. At this point, we do not have
an audit object. The pure calling of the login dialog
also does not create any audit entry, so we do not
pass the audit_object.

fixes #1632
Allow to write policy to audit entry
In case of POST /auth the webui Remote user
policy should be written to the audit entry.

Closes #1632
Merge pull request #1633 from privacyidea/1632/remote-user-audit
Remove audit from remote user fetching

@fredreichbier fredreichbier requested a review from privacyidea/core May 16, 2019

@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #1634 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
+ Coverage   96.94%   96.97%   +0.03%     
==========================================
  Files         148      148              
  Lines       17738    17845     +107     
==========================================
+ Hits        17196    17306     +110     
+ Misses        542      539       -3
Impacted Files Coverage Δ
privacyidea/api/lib/prepolicy.py 97.03% <66.66%> (-0.17%) ⬇️
privacyidea/api/auth.py 95.95% <0%> (+0.22%) ⬆️
privacyidea/lib/eventhandler/base.py 98.65% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6f069...9b0054c. Read the comment docs.

@cornelinux cornelinux merged commit 5cd6730 into master May 18, 2019

4 of 5 checks passed

codecov/patch 66.66% of diff hit (target 96.94%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 96.97% (+0.03%) compared to 4e6f069
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the branch-3.0 branch May 18, 2019

@fredreichbier fredreichbier restored the branch-3.0 branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.