Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 3.0 #1643

Merged
merged 6 commits into from May 25, 2019

Conversation

Projects
None yet
2 participants
@cornelinux
Copy link
Member

commented May 23, 2019

Merge our changes from 3.0.1 into master, including smtp fix and translation.

fredreichbier and others added some commits May 21, 2019

Fix sending mails in combination with CRAM-MD5 authentication
Under Python 2, we need to pass passwords as bytestrings, while Python 3
expects passwords as (unicode) strings.

Fixes #1637
Merge pull request #1638 from privacyidea/1637/smtp-cram-md5
Fix sending mails in combination with CRAM-MD5 authentication

@cornelinux cornelinux requested review from fredreichbier and plettich May 23, 2019

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #1643 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
+ Coverage   96.93%   96.98%   +0.04%     
==========================================
  Files         148      148              
  Lines       17741    17849     +108     
==========================================
+ Hits        17198    17310     +112     
+ Misses        543      539       -4
Impacted Files Coverage Δ
privacyidea/lib/smtpserver.py 98.94% <100%> (+0.04%) ⬆️
privacyidea/api/auth.py 95.95% <0%> (+0.22%) ⬆️
privacyidea/lib/eventhandler/base.py 98.65% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940511...3abf02e. Read the comment docs.

@cornelinux cornelinux merged commit 15c9966 into master May 25, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.93%)
Details
codecov/project 96.98% (+0.04%) compared to 5940511
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.