Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to autoassign during migration #1644

Merged
merged 3 commits into from May 28, 2019

Conversation

Projects
None yet
1 participant
@cornelinux
Copy link
Member

commented May 23, 2019

An additional passthru_assign policy can be used, to
automatically assign a token, when the passthru to the
RADIUS server was successful.

The split_pin_pass method was moved to the lib.utils.
The split_pin_pass in the models.py was removed, since it
is never used in the productive code.

Closes #1619

Add the possibility to autoassign during migration
An additional passthru_assign policy can be used, to
automatically assign a token, when the passthru to the
RADIUS server was successful.

The split_pin_pass method was moved to the lib.utils.
The split_pin_pass in the models.py was removed, since it
is never used in the productive code.

Closes #1619

@cornelinux cornelinux requested a review from privacyidea/core May 23, 2019

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #1644 into master will decrease coverage by 0.09%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1644     +/-   ##
=========================================
- Coverage   96.93%   96.84%   -0.1%     
=========================================
  Files         148      148             
  Lines       17741    17759     +18     
=========================================
+ Hits        17198    17199      +1     
- Misses        543      560     +17
Impacted Files Coverage Δ
privacyidea/models.py 98.91% <ø> (-0.01%) ⬇️
privacyidea/lib/utils.py 97.34% <ø> (-0.37%) ⬇️
privacyidea/lib/tokenclass.py 98.78% <100%> (-0.02%) ⬇️
privacyidea/lib/policy.py 99.2% <100%> (ø) ⬆️
privacyidea/lib/policydecorators.py 98.93% <95.65%> (-0.3%) ⬇️
privacyidea/lib/log.py 34.24% <0%> (-16.44%) ⬇️
privacyidea/lib/subscriptions.py 90.16% <0%> (-0.82%) ⬇️
privacyidea/lib/crypto.py 98.45% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940511...f0ae570. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@42b5a10). Click here to learn what that means.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1644   +/-   ##
=========================================
  Coverage          ?   96.93%           
=========================================
  Files             ?      148           
  Lines             ?    17759           
  Branches          ?        0           
=========================================
  Hits              ?    17215           
  Misses            ?      544           
  Partials          ?        0
Impacted Files Coverage Δ
privacyidea/models.py 98.91% <ø> (ø)
privacyidea/lib/utils.py 97.75% <ø> (ø)
privacyidea/lib/tokenclass.py 98.78% <100%> (ø)
privacyidea/lib/policy.py 99.2% <100%> (ø)
privacyidea/lib/policydecorators.py 98.93% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b5a10...04bc483. Read the comment docs.

@cornelinux cornelinux merged commit 31e5dbe into master May 28, 2019

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@cornelinux cornelinux deleted the 1619/migrate-assign-tokens branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.