Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TiQR token #1740

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@Mipronimo
Copy link
Member

commented Jul 9, 2019

closes #1739

Fix TiQR token
closes #1739

@Mipronimo Mipronimo requested a review from fredreichbier Jul 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #1740 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1740      +/-   ##
==========================================
+ Coverage   97.02%   97.02%   +<.01%     
==========================================
  Files         149      149              
  Lines       18040    18043       +3     
==========================================
+ Hits        17504    17507       +3     
  Misses        536      536
Impacted Files Coverage Δ
privacyidea/lib/tokens/tiqrtoken.py 98.7% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe8ee5...87b8964. Read the comment docs.

@fredreichbier fredreichbier removed their request for review Jul 10, 2019

@fredreichbier

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@Mipronimo Apparently I cannot request a review from you because you're the original author :) (it makes sense, I guess) I just restructured your fix a bit and added a test. Could you have a look at the new logic and check if it still fixes the problem?

@Mipronimo

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

lgtm thanks

@Mipronimo Mipronimo requested a review from fredreichbier Jul 11, 2019

@fredreichbier fredreichbier merged commit 8f5f09f into master Jul 11, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1739/fixTiQRToken branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.