Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebUI for policy conditions #1742

Merged
merged 3 commits into from Jul 19, 2019

Conversation

@fredreichbier
Copy link
Member

commented Jul 11, 2019

This PR makes it possible to edit policy conditions in the WebUI.

Working on #1436

@fredreichbier fredreichbier requested a review from Mipronimo Jul 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #1742 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         149      149           
  Lines       18059    18059           
=======================================
  Hits        17523    17523           
  Misses        536      536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2174a0...65ee04e. Read the comment docs.

@Mipronimo
Copy link
Member

left a comment

lgtm, but I cannot check the technical part (:
I think it is better, if you could also add "contains not" or "!=" to the condition.

@fredreichbier fredreichbier requested a review from plettich Jul 11, 2019

@Mipronimo
Copy link
Member

left a comment

It is easier for non-IT-guys if you would call it "equals" instead of "=="

@plettich
Copy link
Member

left a comment

well, some of the JS/Angular stuff looks like magic but otherwise LGTM.

@@ -0,0 +1,62 @@
<div class="table-responsive">
<table class="table">
<tr ng-repeat="condition in policyConditions">

This comment has been minimized.

Copy link
@plettich

plettich Jul 18, 2019

Member

Maybe we should add a table header to describe the entries in the columns in more detail, so that a user knows, what to put where.

This comment has been minimized.

Copy link
@fredreichbier

fredreichbier Jul 19, 2019

Author Member

Good idea! I added table headings in 65ee04e

@fredreichbier fredreichbier merged commit 5f61b5d into master Jul 19, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a2174a0...65ee04e
Details
codecov/project 97.03% remains the same compared to a2174a0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1436/policy-conditions-webui branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.