Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment UI: Load RADIUS servers only when the user selects RADIUS token #1748

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@fredreichbier
Copy link
Member

commented Jul 16, 2019

This PR postpones the request to /radiusserver/ until the user actually selects the "RADIUS" token type.

Closes #1747

@codecov

This comment has been minimized.

Copy link

commented Jul 16, 2019

Codecov Report

Merging #1748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1748   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         149      149           
  Lines       18059    18059           
=======================================
  Hits        17523    17523           
  Misses        536      536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259e079...b45763d. Read the comment docs.

@plettich
Copy link
Member

left a comment

Looks good

@plettich plettich merged commit b9b2f4f into master Jul 18, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 259e079...b45763d
Details
codecov/project 97.03% remains the same compared to 259e079
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1747/radius-error branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.