Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of endpoint decorators #1752

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@fredreichbier
Copy link
Member

commented Jul 19, 2019

Now, the role check of admin_required is always
performed first.

Closes #1751

@fredreichbier fredreichbier requested a review from plettich Jul 19, 2019

Fix order of endpoint decorators
Now, the role check of ``admin_required`` is always
performed first.

Closes #1751

@fredreichbier fredreichbier force-pushed the 1751/admin-required branch from 4a10eb8 to c46cca6 Jul 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 19, 2019

Codecov Report

Merging #1752 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1752   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         149      149           
  Lines       18059    18059           
=======================================
  Hits        17523    17523           
  Misses        536      536
Impacted Files Coverage Δ
privacyidea/api/caconnector.py 100% <100%> (ø) ⬆️
privacyidea/api/user.py 100% <100%> (ø) ⬆️
privacyidea/api/system.py 96.89% <100%> (ø) ⬆️
privacyidea/api/token.py 98.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f61b5d...c46cca6. Read the comment docs.

@plettich
Copy link
Member

left a comment

looks good

@plettich plettich merged commit e98cefa into master Jul 19, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.03%)
Details
codecov/project 97.03% (+0%) compared to 5f61b5d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1751/admin-required branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.