Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning policy matching against arbitrary userinfo attributes #1753

Merged
merged 5 commits into from Jul 25, 2019

Conversation

@fredreichbier
Copy link
Member

commented Jul 22, 2019

This PR implements some of the open questions mentioned in #1436:

  • We rename == to equals: I think that's more consistent because the other comparators (see below) are English words too
  • We add comparators matches (for regexes) and in
  • We add negated comparators, which are named like ordinary comparators prefixed with !, e.g. !contains

fredreichbier added some commits Jul 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #1753 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   97.03%   97.03%   +<.01%     
==========================================
  Files         149      149              
  Lines       18059    18090      +31     
==========================================
+ Hits        17523    17554      +31     
  Misses        536      536
Impacted Files Coverage Δ
privacyidea/models.py 98.93% <100%> (ø) ⬆️
privacyidea/lib/utils/compare.py 100% <100%> (ø) ⬆️
privacyidea/lib/tokens/yubikeytoken.py 97.67% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98cefa...9c93c15. Read the comment docs.

@fredreichbier fredreichbier marked this pull request as ready for review Jul 24, 2019

@fredreichbier fredreichbier requested a review from plettich Jul 24, 2019

@fredreichbier fredreichbier requested a review from plettich Jul 24, 2019

@plettich
Copy link
Member

left a comment

looks good

@plettich plettich merged commit 6807714 into master Jul 25, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.03%)
Details
codecov/project 97.03% (+<.01%) compared to e98cefa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1436/user-info-finetuning branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.