Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace from key during Yubikey token initialization #1754

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@fredreichbier
Copy link
Member

commented Jul 22, 2019

When enrolling Yubikey (AES mode) tokens, we now strip whitespaces from the OTP key.

I decided to implement the whitespace stripping on the server side because I couldn't think of a nice way to do it in the frontend :-) As it is implemented in the update method of the Yubikey token class, it doesn't interfere with other token classes.

Closes #1735

@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #1754 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   97.03%   97.03%   +<.01%     
==========================================
  Files         149      149              
  Lines       18059    18062       +3     
==========================================
+ Hits        17523    17526       +3     
  Misses        536      536
Impacted Files Coverage Δ
privacyidea/lib/tokens/yubikeytoken.py 97.66% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98cefa...828f13e. Read the comment docs.

@fredreichbier fredreichbier requested a review from plettich Jul 22, 2019

@plettich
Copy link
Member

left a comment

looks good

@plettich

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

In the long run we should move all API test-cases to the test_api_... tests and avoid cluttering the lib test-cases with API initialization stuff.

@plettich plettich merged commit 96b3e18 into master Jul 23, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.03%)
Details
codecov/project 97.03% (+<.01%) compared to e98cefa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fredreichbier fredreichbier deleted the 1735/yubikey-spaces branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.