Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional token-specific plausibility checks during enrollment #1755

Closed
wants to merge 3 commits into from

Conversation

@fredreichbier
Copy link
Member

commented Jul 23, 2019

This PR implements a possible solution of #1631. See the issue for details.

@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

Merging #1755 into master will increase coverage by 0.02%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
+ Coverage   96.99%   97.02%   +0.02%     
==========================================
  Files         149      149              
  Lines       18061    18091      +30     
==========================================
+ Hits        17519    17553      +34     
+ Misses        542      538       -4
Impacted Files Coverage Δ
privacyidea/lib/tokens/hotptoken.py 100% <100%> (ø) ⬆️
privacyidea/lib/policy.py 99.29% <100%> (ø) ⬆️
privacyidea/api/token.py 98.67% <100%> (ø) ⬆️
privacyidea/lib/token.py 96.06% <100%> (+0.02%) ⬆️
privacyidea/api/lib/prepolicy.py 98.29% <100%> (+0.01%) ⬆️
privacyidea/lib/tokenclass.py 98.63% <50%> (-0.17%) ⬇️
privacyidea/models.py 98.86% <0%> (-0.08%) ⬇️
privacyidea/lib/config.py 95.36% <0%> (+0.01%) ⬆️
privacyidea/lib/resolvers/PasswdIdResolver.py 99.13% <0%> (+0.43%) ⬆️
privacyidea/lib/smtpserver.py 98.94% <0%> (+1.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3e18...3c7cc8c. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

Merging #1755 into master will increase coverage by 0.02%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
+ Coverage   96.99%   97.02%   +0.02%     
==========================================
  Files         149      149              
  Lines       18061    18091      +30     
==========================================
+ Hits        17519    17553      +34     
+ Misses        542      538       -4
Impacted Files Coverage Δ
privacyidea/lib/tokens/hotptoken.py 100% <100%> (ø) ⬆️
privacyidea/lib/policy.py 99.29% <100%> (ø) ⬆️
privacyidea/api/token.py 98.67% <100%> (ø) ⬆️
privacyidea/lib/token.py 96.06% <100%> (+0.02%) ⬆️
privacyidea/api/lib/prepolicy.py 98.29% <100%> (+0.01%) ⬆️
privacyidea/lib/tokenclass.py 98.63% <50%> (-0.17%) ⬇️
privacyidea/models.py 98.86% <0%> (-0.08%) ⬇️
privacyidea/lib/config.py 95.36% <0%> (+0.01%) ⬆️
privacyidea/lib/resolvers/PasswdIdResolver.py 99.13% <0%> (+0.43%) ⬆️
privacyidea/lib/smtpserver.py 98.94% <0%> (+1.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3e18...3c7cc8c. Read the comment docs.

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@privacyidea privacyidea deleted a comment from codecov bot Aug 1, 2019

@fredreichbier

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Closing this, as we will do a more thorough rework of the token initialization logic for 3.2. See #1631.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.