Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[RFC] Refactor policy matching, introduce high-level matching API #1757
This implements a high-level policy matching API on top of
login_mode_dict = Match.simple(g, scope=SCOPE.WEBUI, action=ACTION.LOGINMODE, realm=None, user=user_object).action_values(unique=True)
The line reads as follows:
Why do this? :-) Some reasons:
Do you think this is a reasonable refactoring? What do you think of the API?
I realize this is quite a big change, so I would be ok with postponing this until after privacyIDEA 3.1.
@@ Coverage Diff @@ ## master #1757 +/- ## ========================================= - Coverage 97.05% 97% -0.05% ========================================= Files 149 150 +1 Lines 18115 18007 -108 ========================================= - Hits 17581 17468 -113 - Misses 534 539 +5