Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rollout_state condition to eventhandlers #1820

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@cornelinux
Copy link
Member

commented Aug 22, 2019

Closes #1801

@cornelinux cornelinux requested a review from plettich Aug 22, 2019

@cornelinux

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

This helps with the notification in the scenario where users should get the first QR code with the first part of 2step via email.
I am not sure, if we shoud add this to branch-3.1.

@plettich
Copy link
Member

left a comment

looks good

@plettich plettich merged commit 2608889 into master Aug 23, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@plettich plettich deleted the 1801/eventhandler_rollout_state branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.