Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only re-read event handler definitions if the configuration has changed #1824

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@fredreichbier
Copy link
Member

commented Aug 27, 2019

This is achieved by storing the currently defined event handlers in the
shared config object.

Fixes #1823

@fredreichbier fredreichbier added this to In progress in privacyIDEA 3.2 via automation Aug 27, 2019

@fredreichbier fredreichbier force-pushed the 1823/event-handler-config branch from fb7366c to 94838fb Aug 27, 2019

Only re-read event handler definitions if the configuration has changed
This is achieved by storing the currently defined event handlers in the
shared config object.

Fixes #1823
@fredreichbier

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Some performance numbers on a system with a local MySQL and 2 defined event handlers, 1000 successful requests to /validate/check.
On master:

Transactions:		        1000 hits
Availability:		      100.00 %
Elapsed time:		      237.65 secs
Data transferred:	        0.80 MB
Response time:		        0.95 secs
Transaction rate:	        4.21 trans/sec
Throughput:		        0.00 MB/sec
Concurrency:		        3.98
Successful transactions:        1000
Failed transactions:	           0
Longest transaction:	        2.15
Shortest transaction:	        0.54

On 1823/event-handler-config:

Transactions:		        1000 hits
Availability:		      100.00 %
Elapsed time:		      225.86 secs
Data transferred:	        0.80 MB
Response time:		        0.89 secs
Transaction rate:	        4.43 trans/sec
Throughput:		        0.00 MB/sec
Concurrency:		        3.96
Successful transactions:        1000
Failed transactions:	           0
Longest transaction:	        1.92
Shortest transaction:	        0.43

So, it helps a bit, but not that much :) The effect may be greater with a slower database though.

@fredreichbier fredreichbier requested a review from cornelinux Aug 27, 2019

privacyIDEA 3.2 automation moved this from In progress to Reviewer approved Aug 27, 2019

@cornelinux cornelinux merged commit 4599835 into master Aug 27, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

privacyIDEA 3.2 automation moved this from Reviewer approved to Done Aug 27, 2019

@cornelinux cornelinux deleted the 1823/event-handler-config branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.