Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error messages in case of 404 #1830

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@cornelinux
Copy link
Member

commented Aug 28, 2019

The UI now displays an error messages in case of 404

  • actually always when the response does not contain valid JSON.
    (Which is the case in 404 and other errors).

Working on #1674

Display error messages in case of 404
The UI now displays an error messages in case of 404
- actually always when the response does not contain valid JSON.
(Which is the case in 404 and other errors).

Working on #1674

@cornelinux cornelinux requested a review from Mipronimo Aug 28, 2019

@fredreichbier fredreichbier requested review from fredreichbier and removed request for Mipronimo Sep 4, 2019

@fredreichbier
Copy link
Member

left a comment

Looks good!

@fredreichbier fredreichbier merged commit a128999 into master Sep 9, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.