Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also allow Registration token to do chal resp #1898

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Oct 23, 2019

Some tokens like the Registration code could not be
used with challenge response, even if the policy was set.
We changed the Token Base Class to do challenge response,
when the right OTP PIN is given.

Closes #1897

Some tokens like the Registration code could not be
used with challenge response, even if the policy was set.
We changed the Token Base Class to do challenge response,
when the right OTP PIN is given.

Closes #1897
@cornelinux cornelinux requested a review from plettich Oct 23, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1898 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files         151      151              
  Lines       18486    18492       +6     
==========================================
+ Hits        17957    17962       +5     
- Misses        529      530       +1
Impacted Files Coverage Δ
privacyidea/lib/tokens/hotptoken.py 100% <ø> (ø) ⬆️
privacyidea/lib/tokenclass.py 98.8% <100%> (ø) ⬆️
privacyidea/api/before_after.py 97.67% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931e3ae...095dfd4. Read the comment docs.

Copy link
Member

plettich left a comment

Looks good

@plettich plettich merged commit a2bac9b into master Oct 24, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.13%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.86% compared to 931e3ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 1897/chalresp_registration branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.