Join GitHub today
1882/api endpoints without trailing slashes #1899
The `event` and `smsprovider` endpoints were missing a trailing slash in the blueprint, thus calls to `/smsprovider/` would result in a 404. Adding the trailing slash provides a redirect for endpoints without trailing slashes. Also renamed the `id` parameter to `db_id` to avoid shadowing the internal `id` from python.
@@ Coverage Diff @@ ## master #1899 +/- ## ========================================== - Coverage 97.13% 97.13% -0.01% ========================================== Files 151 151 Lines 18486 18484 -2 ========================================== - Hits 17957 17955 -2 Misses 529 529
cornelinux merged commit
Oct 24, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!Details
codecov/patch 100% of diff hit (target 97.13%)Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.86% compared to e31765aDetails
continuous-integration/travis-ci/pr The Travis CI build passedDetails
continuous-integration/travis-ci/push The Travis CI build passedDetails
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.