Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseProvider Enhancements for Push Tokens #1900

Open
wants to merge 1 commit into
base: master
from

Conversation

@droobah
Copy link
Contributor

droobah commented Oct 23, 2019

Changes to FCM message payload are required for push notifications to work properly on iOS in all app states (foreground, background, terminated). The apns-* and aps sections are required/recommended per Apple's developer documentation. Adding the category tag for Apple Push Services enables the 'Allow' button to work at the notification screen on iOS as well as from notifications that are pushed to the Apple Watch.

Added TTL for push notifications so they automatically remove themselves from Firebase storage if they are too old to be useful for both iOS and Android.

Added FCM tags for reporting/analytics on the Firebase Console per Google's recommendation.

  all app states (foreground, background, terminated)
- enables 'Allow' button from notification to be tapped to respond
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         151      151           
  Lines       18486    18486           
=======================================
  Hits        17957    17957           
  Misses        529      529
Impacted Files Coverage Δ
privacyidea/lib/smsprovider/FirebaseProvider.py 97.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31765a...030d58f. Read the comment docs.

@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Oct 24, 2019

Thanks a lot for this PR. Can you please open an issue for this and refer the PR to the issue. We try to do no PR without an issue, so that details things can be discussed in the issue (and do not need to be discussed in some comments of the PR)
Thanks!

@droobah

This comment has been minimized.

Copy link
Contributor Author

droobah commented Oct 24, 2019

Fixes #1903

@cornelinux cornelinux requested a review from NuvandaPV Nov 18, 2019
@cornelinux cornelinux added this to In progress in privacyIDEA 3.2 via automation Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
privacyIDEA 3.2
  
In progress
2 participants
You can’t perform that action at this time.