Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make 'splitAtSign' more consistent #1905
@@ Coverage Diff @@ ## master #1905 +/- ## ========================================== + Coverage 97.13% 97.13% +<.01% ========================================== Files 151 151 Lines 18475 18481 +6 ========================================== + Hits 17946 17952 +6 Misses 529 529
cornelinux left a comment
lgtm. Thanks a lot.
I have only some style requests and some understanding requests.
In addition I think we should somewhere document more precisely how the handling is done.
- the `splitAtSign` configuration is `True` by default and will be always be set. So we don't need a `default` option when requesting the config. - set the `spligAtSign` configuration explicitly in tests - test for admin authentication - test user lib with `splitAtSign` configuration