Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the token-janitor user output #1906

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Oct 27, 2019

Catch exceptions if user resolving fails.
Add realm to the user output

Closes #1070

Catch exceptions if user resolving fails.
Add realm to the user output

Closes #1070
@cornelinux cornelinux requested a review from plettich Oct 27, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #1906 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
+ Coverage   97.13%   97.14%   +<.01%     
==========================================
  Files         151      151              
  Lines       18475    18549      +74     
==========================================
+ Hits        17946    18019      +73     
- Misses        529      530       +1
Impacted Files Coverage Δ
privacyidea/lib/user.py 99.34% <0%> (+0.04%) ⬆️
privacyidea/api/auth.py 97.2% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bac9b...63ffbeb. Read the comment docs.

tools/privacyidea-token-janitor Outdated Show resolved Hide resolved
tools/privacyidea-token-janitor Outdated Show resolved Hide resolved
Add review comments
@cornelinux cornelinux requested a review from plettich Oct 28, 2019
@plettich plettich merged commit 8d1d50b into master Oct 30, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a2bac9b...63ffbeb
Details
codecov/project 97.14% (+<.01%) compared to a2bac9b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 1070/streamline_janitor_user_output branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.