Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling of privacyidea cron #1913

Conversation

@chamkad
Copy link

chamkad commented Nov 4, 2019

Add --retry and --period to try execution the failed jobs, to write the current timestamp for them in the database to periodictasklastrun table.

Add retry and period between retries for failing jobs in the run_scheduled operation.
@chamkad chamkad changed the title Update privacyidea-cron Improve-error-handling-of-privacyidea-cron Nov 4, 2019
@chamkad chamkad changed the title Improve-error-handling-of-privacyidea-cron Improve error handling of privacyidea cron Nov 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #1913 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         151      151           
  Lines       18481    18481           
=======================================
  Hits        17952    17952           
  Misses        529      529

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1d50b...58604b3. Read the comment docs.

@cornelinux

This comment has been minimized.

Copy link
Member

cornelinux commented Nov 16, 2019

I thin retrying is a bad idea.
This could pile up, if something does not work at all.
You can end up with endlos jobs, that are retrying.

@cornelinux cornelinux closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.