Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for a file audit module #1936

Merged
merged 3 commits into from Nov 22, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Nov 18, 2019

Closes #1935

Closes #1935
@cornelinux cornelinux requested a review from plettich Nov 18, 2019
Closes #1935
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #1936 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1936      +/-   ##
==========================================
+ Coverage   97.13%   97.21%   +0.08%     
==========================================
  Files         153      153              
  Lines       18556    18556              
==========================================
+ Hits        18024    18040      +16     
+ Misses        532      516      -16
Impacted Files Coverage Δ
privacyidea/app.py 93.07% <0%> (+2.3%) ⬆️
privacyidea/lib/log.py 68.49% <0%> (+17.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960e4eb...51810b8. Read the comment docs.

Copy link
Member

plettich left a comment

I'll add the changes.

privacyidea/config.py Outdated Show resolved Hide resolved
tests/base.py Outdated Show resolved Hide resolved
This avoids cluttering the privacyIDEA config class and the base test
class.
@plettich plettich self-requested a review Nov 22, 2019
Copy link
Member

plettich left a comment

looks good :-)

@plettich plettich merged commit fb4ceaf into master Nov 22, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 960e4eb...51810b8
Details
codecov/project 97.21% (+0.08%) compared to 960e4eb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 1935/fileaudit_test branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.