Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try..except to first migration script #1942

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@plettich
Copy link
Member

plettich commented Nov 26, 2019

In case a database isn't stamped, a pi-manage db upgrade will start with
the first migration script and run into an error since there is no error
checking.

Working on #1875

In case a database isn't stamped, a `pi-manage db upgrade` will start with
the first migration script and run into an error since there is no error
checking.
@plettich plettich requested a review from cornelinux Nov 26, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #1942 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   97.21%   97.26%   +0.04%     
==========================================
  Files         153      153              
  Lines       18555    18891     +336     
==========================================
+ Hits        18039    18375     +336     
  Misses        516      516
Impacted Files Coverage Δ
privacyidea/lib/tokens/hotptoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/totptoken.py 99.27% <0%> (+0.41%) ⬆️
privacyidea/lib/eventhandler/usernotification.py 93.51% <0%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d679b02...86efb30. Read the comment docs.

@cornelinux cornelinux merged commit f6e2c4c into master Nov 26, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d679b02...86efb30
Details
codecov/project 97.26% (+0.04%) compared to d679b02
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.