Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to fix the user -> username #1949

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Nov 29, 2019

Otherwise the name of the user will not be passed to
the privacyIDEA processing, policies will not match and
the user will not be written to the audit log.

Fix in #1773

Otherwise the name of the user will not be passed to
the privacyIDEA processing, policies will not match and
the user will not be written to the audit log.

Fix in #1773
@cornelinux cornelinux requested a review from plettich Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1949 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
+ Coverage   97.18%   97.21%   +0.03%     
==========================================
  Files         153      153              
  Lines       18554    18555       +1     
==========================================
+ Hits        18032    18039       +7     
+ Misses        522      516       -6
Impacted Files Coverage Δ
privacyidea/config.py 100% <ø> (ø) ⬆️
privacyidea/api/lib/utils.py 97.56% <100%> (ø) ⬆️
privacyidea/lib/config.py 95.43% <0%> (+0.01%) ⬆️
privacyidea/lib/resolvers/PasswdIdResolver.py 99.13% <0%> (+0.43%) ⬆️
privacyidea/lib/smtpserver.py 98.94% <0%> (+1.05%) ⬆️
privacyidea/lib/tokens/yubikeytoken.py 97.66% <0%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beac11d...667f9eb. Read the comment docs.

@cornelinux cornelinux merged commit 7948af7 into master Nov 29, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.18%)
Details
codecov/project 97.21% (+0.03%) compared to beac11d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@cornelinux cornelinux deleted the fix_trusted_jwt branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.