Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token handler options with Python 3 #1951

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Nov 29, 2019

The options of the token handler returned a range,
which is an generator in python 3.
This would break during serialization.

Casting it to a list.

The options of the token handler returned a range,
which is an generator in python 3.
This would break during serialization.

Casting it to a list.
@cornelinux cornelinux requested a review from plettich Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1951 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   97.21%   97.21%   -0.01%     
==========================================
  Files         153      153              
  Lines       18555    18576      +21     
==========================================
+ Hits        18039    18059      +20     
- Misses        516      517       +1
Impacted Files Coverage Δ
privacyidea/lib/eventhandler/tokenhandler.py 96.29% <ø> (ø) ⬆️
privacyidea/lib/smsprovider/FirebaseProvider.py 97% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb7c1f...b173282. Read the comment docs.

Copy link
Member

plettich left a comment

looks good

@plettich plettich merged commit 4804cd8 into master Nov 29, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 97.21% (-0.01%) compared to eeb7c1f
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing eeb7c1f...b173282
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the fix-range-in-response branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.