Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tokenrealm in UI #1964

Merged
merged 3 commits into from Dec 19, 2019
Merged

Filter tokenrealm in UI #1964

merged 3 commits into from Dec 19, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Dec 12, 2019

The token table in the UI contains a filter field for the tokenrealm.
It filters for a substring of all realms, that the token
is assigned to.

Closes #545

The token table in the UI contains a filter field for the tokenrealm.
It filters for a substring of all realms, that the token
is assigned to.

Closes #545
@cornelinux cornelinux requested a review from NuvandaPV Dec 12, 2019
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Dec 12, 2019

Hello @cornelinux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 189:80: E501 line too long (107 > 79 characters)
Line 195:80: E501 line too long (86 > 79 characters)

Comment last updated at 2019-12-19 15:09:43 UTC
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1964 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1964      +/-   ##
==========================================
+ Coverage   97.21%   97.38%   +0.16%     
==========================================
  Files         153      153              
  Lines       18555    20241    +1686     
==========================================
+ Hits        18039    19711    +1672     
- Misses        516      530      +14
Impacted Files Coverage Δ
privacyidea/lib/token.py 95.94% <100%> (+0.01%) ⬆️
privacyidea/lib/tokens/foureyestoken.py 89.51% <0%> (-1.3%) ⬇️
privacyidea/lib/tokens/yubicotoken.py 95.07% <0%> (-0.93%) ⬇️
privacyidea/lib/tokens/pushtoken.py 97.1% <0%> (-0.49%) ⬇️
privacyidea/lib/tokens/remotetoken.py 98.79% <0%> (-0.28%) ⬇️
privacyidea/lib/tokens/yubikeytoken.py 97.63% <0%> (-0.03%) ⬇️
privacyidea/lib/tokens/emailtoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/passwordtoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/papertoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/hotptoken.py 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154dfdd...c9e63b5. Read the comment docs.

Copy link
Contributor

NuvandaPV left a comment

Looks good to me. Currently a user typing too fast will cause exceptions to be thrown though. Should we do something about that?

@cornelinux

This comment has been minimized.

Copy link
Member Author

cornelinux commented Dec 19, 2019

Looks good to me. Currently a user typing too fast will cause exceptions to be thrown though. Should we do something about that?

How is that?
This would probably happen in all filter components? If so, I would leave this as a generic new issue.

@NuvandaPV NuvandaPV self-requested a review Dec 19, 2019
@NuvandaPV NuvandaPV merged commit 39849a0 into master Dec 19, 2019
6 checks passed
6 checks passed
greeting
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.21%)
Details
codecov/project 97.38% (+0.16%) compared to 3bb65bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.