Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No link on Logo, if no user is logged in #1965

Merged
merged 1 commit into from Dec 19, 2019
Merged

No link on Logo, if no user is logged in #1965

merged 1 commit into from Dec 19, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Dec 12, 2019

The logo in the WebUI should only have a link,
if a user is logged in.

Closes #1944

The logo in the WebUI should only have a link,
if a user is logged in.

Closes #1944
@cornelinux cornelinux requested a review from NuvandaPV Dec 12, 2019
@cornelinux

This comment has been minimized.

Copy link
Member Author

cornelinux commented Dec 12, 2019

There may be more elegant solutions, but I could not figure something out without adding any new directives, which seemed like overkill to me.

Copy link
Contributor

NuvandaPV left a comment

Not pretty but works. I don't think there is a better way to do this on a version of angular this old.

@NuvandaPV NuvandaPV merged commit a8188d7 into master Dec 19, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.