Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup created files after CA test #1968

Merged
merged 5 commits into from Dec 20, 2019
Merged

Cleanup created files after CA test #1968

merged 5 commits into from Dec 20, 2019

Conversation

@cornelinux
Copy link
Member

cornelinux commented Dec 16, 2019

Closes #1960

Closes #1960
@cornelinux cornelinux requested a review from plettich Dec 16, 2019
@privacyidea privacyidea deleted a comment from pep8speaks Dec 16, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1968 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   97.22%   97.48%   +0.26%     
==========================================
  Files         153      153              
  Lines       18590    20706    +2116     
==========================================
+ Hits        18074    20186    +2112     
- Misses        516      520       +4
Impacted Files Coverage Δ
privacyidea/lib/tokens/foureyestoken.py 89.51% <0%> (-1.4%) ⬇️
privacyidea/lib/tokens/yubicotoken.py 95.07% <0%> (-0.97%) ⬇️
privacyidea/lib/tokens/pushtoken.py 97.1% <0%> (-0.49%) ⬇️
privacyidea/lib/tokens/remotetoken.py 98.79% <0%> (-0.28%) ⬇️
privacyidea/lib/tokens/emailtoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/passwordtoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/vascotoken.py 93.93% <0%> (ø) ⬆️
privacyidea/lib/tokens/papertoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/hotptoken.py 100% <0%> (ø) ⬆️
privacyidea/lib/tokens/daplugtoken.py 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f5f2d...016287d. Read the comment docs.

tests/test_lib_caconnector.py Outdated Show resolved Hide resolved
tests/test_lib_caconnector.py Outdated Show resolved Hide resolved
tests/test_lib_caconnector.py Outdated Show resolved Hide resolved
tests/test_lib_caconnector.py Outdated Show resolved Hide resolved
tests/test_lib_caconnector.py Outdated Show resolved Hide resolved
Incorporate review comments

Closes #1960
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Dec 20, 2019

Hello @cornelinux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-20 11:18:59 UTC
@cornelinux cornelinux requested a review from plettich Dec 20, 2019
cornelinux and others added 2 commits Dec 20, 2019
Also update git-ignore for ca directory
Copy link
Member

plettich left a comment

looks good

@plettich plettich merged commit 72856d8 into master Dec 20, 2019
6 checks passed
6 checks passed
greeting
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 0bdf8f2...016287d
Details
codecov/project 97.48% (+0.26%) compared to 0bdf8f2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 1960/cleanup-ca-tests branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.