Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning for AngularJS components #1969

Merged
merged 6 commits into from Dec 19, 2019
Merged

Conversation

@NuvandaPV
Copy link
Contributor

NuvandaPV commented Dec 16, 2019

No description provided.

@NuvandaPV NuvandaPV requested a review from cornelinux Dec 16, 2019
@NuvandaPV NuvandaPV self-assigned this Dec 16, 2019
@NuvandaPV

This comment has been minimized.

Copy link
Contributor Author

NuvandaPV commented Dec 16, 2019

fixes #1871

/*
* A suffix, that can be appended to an url to invalidate the caches when necessary.
*
* This factory will provide a provider to provide a suffix for an url that sets a parameter `v` to either the

This comment has been minimized.

Copy link
@cornelinux

cornelinux Dec 16, 2019

Member

Admit it - you constructed this sentence on purpose! :-)

Copy link
Member

cornelinux left a comment

lgtm.
But I have some naming concerns. (what did you expect? ;-)

* across updates of the privacyIDEA server software and not if the user is running a development version of
* privacyIDEA.
*/
versioning.provider('versioningSuffixProvider', [

This comment has been minimized.

Copy link
@cornelinux

cornelinux Dec 16, 2019

Member

Is there a deeper idea why call this provider "...Provider"?
We end up calling

versioningSuffixProviderProvider.$get().$get()

which is rather difficult to type when adding a new route.

As the versioing is always a suffix(?) wouldn't it be possible to simply call it 'versioning' to end up with versioningProvider?

@cornelinux cornelinux merged commit 13a94db into master Dec 19, 2019
4 checks passed
4 checks passed
greeting
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@cornelinux cornelinux deleted the 1871/versioning-ng-components branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.