Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore setrealm policy if no user is given #1970

Merged
merged 1 commit into from Dec 19, 2019
Merged

Conversation

@cornelinux
Copy link
Member

cornelinux commented Dec 18, 2019

Fixes #1943

Fixes #1943
@cornelinux cornelinux requested a review from plettich Dec 18, 2019
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Dec 18, 2019

Hello @cornelinux! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 476:80: E501 line too long (83 > 79 characters)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         153      153           
  Lines       18555    18555           
=======================================
  Hits        18039    18039           
  Misses        516      516
Impacted Files Coverage Δ
privacyidea/api/lib/prepolicy.py 97.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f5f2d...2da12dd. Read the comment docs.

Copy link
Member

plettich left a comment

Looks good

@plettich plettich merged commit 562c8b1 into master Dec 19, 2019
6 checks passed
6 checks passed
greeting
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.21%)
Details
codecov/project 97.21% (+0%) compared to 3bb65bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 1943/toketest_setrealm branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.