Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sorting of token table #2112

Merged
merged 2 commits into from Mar 20, 2020
Merged

Fix the sorting of token table #2112

merged 2 commits into from Mar 20, 2020

Conversation

@cornelinux
Copy link
Member

cornelinux commented Mar 19, 2020

The API expects a lowercase "sortby".
The directive returns a lowercase "sortby".
So lowercasing the parameters.

Fixes #2111

The API expects a lowercase "sortby".
The directive returns a lowercase "sortby".
So lowercasing the parameters.

Fixes #2111
@cornelinux cornelinux requested a review from plettich Mar 19, 2020
The token/challenge endpoint also expects a lower case
"sortby".
@cornelinux cornelinux requested a review from plettich Mar 19, 2020
Copy link
Member

plettich left a comment

Looks good

@plettich plettich merged commit 4c4004b into master Mar 20, 2020
4 checks passed
4 checks passed
runner / codespell
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@plettich plettich deleted the 2111/fix-token-sorting branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.