Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stateChangeSuccess by transitions.onBefore and onSuccess #2126

Merged
merged 2 commits into from Mar 23, 2020

Conversation

@cornelinux
Copy link
Member

cornelinux commented Mar 22, 2020

In the new angular-ui-router the event stateChangeSuccess has
been removed. The changing of a state is now handled by
hooks to transitions
onBefore and onSuccess.
In the onBefore hook we now need to save the current state
and parameters, so that we can return to this state, when needed.

Fixes #2122

In the onSuccess hook we if all Listeners have reloaed.

Fixes #2125

In the new angular-ui-router the event stateChangeSuccess has
been removed. The changing of a state is now handled by
hooks to transitions
onBefore and onSuccess.
In the onBefore hook we now need to save the *current* state
and parameters, so that we can return to this state, when needed.

Fixes #2122

In the onSuccess hook we if all Listeners have reloaed.

Fixes #2125
@cornelinux cornelinux requested a review from plettich Mar 22, 2020
@cornelinux cornelinux added this to In progress in privacyIDEA 3.3 via automation Mar 22, 2020
following the review comment.
@cornelinux cornelinux requested a review from plettich Mar 23, 2020
@cornelinux cornelinux merged commit 5805b52 into master Mar 23, 2020
4 checks passed
4 checks passed
runner / codespell
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
privacyIDEA 3.3 automation moved this from In progress to Done Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.