New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MariaDB as database when installing from packages #671
Conversation
MariaDB is a drop in replacement (as they like to say) for Oracle MySQL. Debian and other distributions has made it clear that MariaDB will be the default database instead of Oracle MySQL. This patch makes it possible to install PrivacyIDEA with MariaDB.
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 95.4% 95.39% -0.02%
==========================================
Files 92 120 +28
Lines 14016 14569 +553
==========================================
+ Hits 13372 13898 +526
- Misses 644 671 +27
Continue to review full report at Codecov.
|
In the post install script we are using the |
Today I installed a new virtual machine and it did work.
Solution to problem above is to run this
|
Thanks for your PR. Looks good anyway. |
MariaDB is a drop in replacement (as they like to say) for Oracle MySQL. Debian and other distributions has made it clear that MariaDB will be the default database instead of Oracle MySQL.
This patch makes it possible to install PrivacyIDEA with MariaDB.
It needs to be tested so dependencies in the package python-mysqldb does not create any conflicts or problem in PrivacyIDEA. On my Ubuntu 16.04 it does not create any problem but am not testing on a clean system.
80% <0%> (-10.15%)
92.15% <0%> (-5.02%)
92% <0%> (-3.56%)
98.61% <0%> (-1.39%)
95.69% <0%> (-0.18%)
100% <0%> (ø)
100% <0%> (ø)
100% <0%> (ø)
94% <0%> (ø)
Continue to review full report at Codecov.
mysql
command line client to set up the database automatically. Can you confirm that this works out with the mariadb-server/client?