Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: document iOS 14+ & macOS Big Sur encrypted DNS #2099

Merged
merged 7 commits into from Oct 22, 2020

Conversation

@Mikaela
Copy link
Contributor

@Mikaela Mikaela commented Oct 21, 2020

Description

Resolves: #2059
Resolves: #2096

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

    • I am not sure if AdGuard profiles cont as it's listed above on the page.
    • I don't know if NextDNS profile generator is open source.
    • encrypted-dns.party is open source.
@Mikaela
Copy link
Contributor Author

@Mikaela Mikaela commented Oct 21, 2020

I am opening this PR to show that I am working on this and to hopefully not duplicate work. I pushed this so heavy WIP as I want to work on this on another computer and the easiest way to do that with git is pushing it.

@Mikaela Mikaela changed the title [HEAVY WIP] DNS: document iOS 14+ & macOS Big Sur encrypted DNS DNS: document iOS 14+ & macOS Big Sur encrypted DNS Oct 21, 2020
@Mikaela Mikaela marked this pull request as ready for review Oct 21, 2020
@Mikaela Mikaela requested a review from privacytools/editorial as a code owner Oct 21, 2020
open in Safari, others won't work
@Mikaela
Copy link
Contributor Author

@Mikaela Mikaela commented Oct 21, 2020

I think the only way to make this prettier would be delisting DNSCloak or demoting it as a third option after unsigned profiles. Thoughts?

@freddy-m
Copy link
Collaborator

@freddy-m freddy-m commented Oct 21, 2020

I don't think that it looks ugly as it is, certainly an improvement from when it was in card format.

Copy link
Collaborator

@freddy-m freddy-m left a comment

LGTM

@Mikaela Mikaela requested a review from freddy-m Oct 22, 2020
Copy link
Collaborator

@freddy-m freddy-m left a comment

Looks even better to me (I hate reviewing things first).

@freddy-m freddy-m merged commit 7db82b2 into privacytools:master Oct 22, 2020
5 checks passed
5 checks passed
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed 2 new files uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@netlify
Mixed content No mixed content detected
Details
@netlify
deploy/netlify Deploy preview ready!
Details
@Mikaela Mikaela deleted the Mikaela:appledns2 branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants