Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added uberspace to hosting providers #1289

Open
wants to merge 5 commits into
base: master
from

Conversation

@MarkusZoppelt
Copy link

MarkusZoppelt commented Sep 10, 2019

@MarkusZoppelt MarkusZoppelt requested a review from privacytoolsIO/editorial as a code owner Sep 10, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Sep 10, 2019

Deploy preview for privacytools-io ready!

Built with commit 5c87c28

https://deploy-preview-1289--privacytools-io.netlify.com

Copy link
Member

Mikaela left a comment

I have listed the source code.

You haven't edited source_code.md

This project is free/libre software.

Where is the source code?

This project has an associated discussion.

I find no issues with the search "uberspace".

Code Repository (if applicable):
https://github.com/MarkusZoppelt/privacytools.io

Of uberspace?

@blacklight447-ptio

This comment has been minimized.

Copy link
Member

blacklight447-ptio commented Sep 10, 2019

Could you first open an issue for discussion please. im very uneasy approving stuff that have not had an associated discussion.

@MarkusZoppelt

This comment has been minimized.

Copy link
Author

MarkusZoppelt commented Sep 10, 2019

Just opened a discussion. It is not free software though.
Is that a problem for listing a privacy-friendly hosting provider?

@blacklight447-ptio

This comment has been minimized.

Copy link
Member

blacklight447-ptio commented Sep 10, 2019

Just opened a discussion. It is not free software though.
Is that a problem for listing a privacy-friendly hosting provider?

Not really, mostly because people cannot see whether the open source software is really the thing that's running on the server anyway.

@Mikaela

This comment has been minimized.

Copy link
Member

Mikaela commented Sep 10, 2019

For me a bigger problem was the incorrectly checked boxes.

I will be opening a PR to clarify the template.

@ggg27

This comment has been minimized.

Copy link
Contributor

ggg27 commented Sep 10, 2019

I would like to see #1196 get closed first.


I plan to launch a PR soon if we don't get any responses.

  • Not certain if the PTIO team missed it? (response)
@ggg27

This comment has been minimized.

Copy link
Contributor

ggg27 commented Sep 10, 2019

@blacklight447-ptio Are users still supposed to create a discussion issue before PR?

@blacklight447-ptio

This comment has been minimized.

Copy link
Member

blacklight447-ptio commented Sep 10, 2019

We are currently busy with the new browser page and email was actually the next on our list to undertake and make solid requirements for.

@ggg27

This comment has been minimized.

Copy link
Contributor

ggg27 commented Sep 10, 2019

@blacklight447-ptio Alright, I would appreciate feedback if any of you ever have a chance.
I do not want to post a PR without any discussion on it yet. :)


I did want to re-ping you if there needed to have a discussion thread first?
Edit: I see, #1290 . - Sorry

@Mikaela Mikaela referenced this pull request Nov 4, 2019
1 of 2 tasks complete
Copy link
Member

Mikaela left a comment

I have looked into Uberspace's websites and attempted to DDG about them and I am fine with the inclusion (with the usual complaints about our criteria and missing warnings, but that is out of scope for this PR).

I just wish some clarifications in my review comments and then I am fine with the PR, thank you.

_includes/sections/hosting-provider.html Outdated Show resolved Hide resolved
_includes/sections/hosting-provider.html Outdated Show resolved Hide resolved
_includes/sections/hosting-provider.html Outdated Show resolved Hide resolved
_includes/sections/hosting-provider.html Outdated Show resolved Hide resolved
MarkusZoppelt and others added 3 commits Nov 4, 2019
Co-Authored-By: Mikaela Suomalainen <mikaela@mikaela.info>
moved uberspace to the bottom in the order where it has been added
edited uberspace description
@Mikaela
Mikaela approved these changes Nov 4, 2019
Copy link
Member

Mikaela left a comment

Thanks :)

There just seems to be a merge conflict (I hope I didn't cause it) and GitHub doesn't email about synced pull requests, so I wouldn't have noticed this if I didn't happen to notice this on #git:privacytools.io.

@Mikaela

This comment has been minimized.

Copy link
Member

Mikaela commented Nov 4, 2019

I don't understand what it conflicted about looking at the GitHub conflict resolving interface, I hope you don't mind me committing (and editing your comments).

@Mikaela Mikaela requested a review from privacytoolsIO/editorial Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.