Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-engines: delist startpage #1410

Merged
merged 4 commits into from Nov 12, 2019

Conversation

@Mikaela
Copy link
Member

Mikaela commented Oct 15, 2019

@Mikaela Mikaela requested a review from privacytoolsIO/editorial as a code owner Oct 15, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 15, 2019

Deploy preview for privacytools-io ready!

Built with commit 79dc3f4

https://deploy-preview-1410--privacytools-io.netlify.com

@Mikaela

This comment has been minimized.

Copy link
Member Author

Mikaela commented Oct 17, 2019

In case anyone finds here, but not the discussion, it's in two places #1409 (comment) and our forum before the WIP (don't merge/PR) label gets removed and anything happens with this PR.

With luck I think we may even be able to close this issue and not delist Startpage, but it's too early to say.

@Mikaela Mikaela removed the WIP label Oct 27, 2019
Mikaela added 2 commits Oct 15, 2019
Resolves: #1409
@Mikaela Mikaela force-pushed the Mikaela:delist-startpage branch from 5984a11 to fd27b97 Oct 27, 2019
@Mikaela

This comment has been minimized.

Copy link
Member Author

Mikaela commented Oct 27, 2019

I also fixed the merge conflict and removed the WIP label, even while I am not sure if a concensus was reached, I am ~10 days behind on everything.

@Mikaela

This comment has been minimized.

Copy link
Member Author

Mikaela commented Nov 10, 2019

@privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation?

CC: @LizMcIntyre

@LizMcIntyre

This comment has been minimized.

Copy link
Contributor

LizMcIntyre commented Nov 10, 2019

@privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation?

CC: @LizMcIntyre

Hi @Mikaela @blacklight447-ptio I believe something should be posted to note the removal. I'm thinking a short comment is best. Here's the latest I recommended in the discussion thread:

The Startpage search engine is de-listed until it is fully transparent about its new ownership and data processing.

People can click the link to get the details.

I believe that once PrivacytoolsIO recommends a service, it should indicate that a service is removed and why it is removed. This will help alert those who use a recommended service that has lost trust. How else might they know?

A press release and other media might also be a good idea because some people might not return to see a warning.

Co-authored-by: Liz McIntyre <LizMcIntyre@users.noreply.github.com>
@Mikaela Mikaela dismissed stale reviews from dawidpotocki and nitrohorse via ff5ef96 Nov 10, 2019
@Mikaela Mikaela requested review from nitrohorse and dawidpotocki Nov 10, 2019
@Mikaela

This comment has been minimized.

Copy link
Member Author

Mikaela commented Nov 10, 2019

@privacytoolsIO/editorial & @LizMcIntyre, please rereview changes at https://github.com/privacytoolsIO/privacytools.io/pull/1410/files + consider can we merge it.

I have no comment on the rest at the moment.

Copy link
Contributor

djoate left a comment

Also, I think it would look better if the warning text wasn't in the middle of the cards but rather at the bottom of the cards

website="https://www.startpage.com/"
forum="https://forum.privacytools.io/t/discussion-startpage/284"
%}
<p><strong>The Startpage search engine is de-listed until it is fully transparent about <a href="https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/">its new ownership</a> and data processing.</strong></p>

This comment has been minimized.

Copy link
@djoate

djoate Nov 10, 2019

Contributor
Suggested change
<p><strong>The Startpage search engine is de-listed until it is fully transparent about <a href="https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/">its new ownership</a> and data processing.</strong></p>
<p><strong>The Startpage search engine is delisted until it is fully transparent about <a href="https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/">its new ownership</a> and data processing.</strong></p>

This comment has been minimized.

Copy link
@nitrohorse

nitrohorse Nov 11, 2019

Member

Yeah, I agree; the warning in the middle does look a bit odd.

@blacklight447-ptio

This comment has been minimized.

Copy link
Member

blacklight447-ptio commented Nov 11, 2019

Tbh, do we want the post delisting on the website now? It goes a bit against what we normally do, i would personally opt to just remove it, and put out a small blog post.

@nitrohorse

This comment has been minimized.

Copy link
Member

nitrohorse commented Nov 11, 2019

You’re right, that would make more sense overall I think.

@Mikaela

This comment has been minimized.

Copy link
Member Author

Mikaela commented Nov 11, 2019

Trai comments:

Mikaela, if we make an announcement out of it, let's also include the r/PTIO post that Liz referenced in your linked pull request: https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/
It's more informative, and includes links to other posts that include SP's response (such as it is).
It'll let readers go as deep as they'd like to go.

So should I:

  • revert ff5ef96 ?
  • move the warning to bottom and add link to Privacytools subreddit?
@blacklight447-ptio

This comment has been minimized.

Copy link
Member

blacklight447-ptio commented Nov 11, 2019

I would just remove startpage, add nothing else, then publish a blog explaining the removal.

This reverts commit ff5ef96.
@Mikaela Mikaela requested a review from blacklight447-ptio Nov 11, 2019
@LizMcIntyre

This comment has been minimized.

Copy link
Contributor

LizMcIntyre commented Nov 11, 2019

I would just remove startpage, add nothing else, then publish a blog explaining the removal.

That could work, too. Less disruptive to the flow and tradition, as pointed out.

@JonahAragon JonahAragon merged commit 9a156bc into privacytoolsIO:master Nov 12, 2019
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
deploy/netlify Deploy preview ready!
Details
@JonahAragon JonahAragon deleted the Mikaela:delist-startpage branch Nov 12, 2019
@Mikaela Mikaela restored the Mikaela:delist-startpage branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.