Enable jemalloc for Mac environments #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was enabled already for x86 Macs, ARM has the same level of support. I ran a couple of benchmarks and everything seems to be working just fine
|
Some evidence that it actually works on my mac raw-ipa [jemalloc-mac] cargo bench --bench oneshot_ipa --no-default-features --features="enable-benches" -- -n 10
Finished bench [optimized] target(s) in 1.52s
Running benches/oneshot/ipa.rs (target/release/deps/oneshot_ipa-4592e5cae60a2dc6)
Using random seed: 7588862210012395418 for 10 records
Preparation complete in 3.233167ms
Malicious IPA for 10 records took 346.345292ms |
|
It is funny but jemalloc works better on ARM Macs: tikv/jemallocator#17 |
|
Verified that jemalloc works on my M1 Mac, too. |
martinthomson
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was enabled already for x86 Macs, ARM has the same level of support. I ran a couple of benchmarks and everything seems to be working just fine