Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout argument annotation #133

Merged
merged 6 commits into from
Jan 4, 2019
Merged

Add timeout argument annotation #133

merged 6 commits into from
Jan 4, 2019

Conversation

daa
Copy link
Contributor

@daa daa commented Dec 29, 2018

Fixes #131 .

Changes proposed in this pull request:

  • add Timeout argument annotation to be able to pass timeout as consumer method argument or to inject it as transaction hook
  • add Identity converter key to pass given value as is to use it in Timeout described above

Attention: @prkumar

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #133   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          35     35           
  Lines        1853   1869   +16     
  Branches      155    155           
=====================================
+ Hits         1853   1869   +16
Impacted Files Coverage Δ
uplink/arguments.py 100% <100%> (ø) ⬆️
uplink/converters/keys.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6dcf9...f03cbb6. Read the comment docs.

@prkumar
Copy link
Owner

prkumar commented Jan 4, 2019

@daa - Thanks for taking time to address this! Your changes look good to merge as-is!

@prkumar prkumar merged commit c222663 into prkumar:master Jan 4, 2019
@prkumar
Copy link
Owner

prkumar commented Jan 4, 2019

@daa - Just to follow up: if you'd like your name to appear in the AUTHORS.rst file, please let me know what name and/or public handle (e.g., @daa) that you'd like me to append to the file. For example, here's my entry in that file:

Raj Kumar (@prkumar)

Alternatively, you could open a separate PR with that change. Whatever works best for you!

@prkumar prkumar added this to the v0.8.0 milestone Jan 4, 2019
@daa daa deleted the timeout-argument branch January 5, 2019 15:56
@daa
Copy link
Contributor Author

daa commented Jan 7, 2019

Thank you very much, you may mention me as Alexander Duryagin (@daa).

@prkumar prkumar mentioned this pull request Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants