Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved methods for saving results #65

Merged
merged 14 commits into from Jun 15, 2019

Conversation

Projects
None yet
2 participants
@prmiles
Copy link
Owner

commented Jun 15, 2019

  • User can now save a lighter version of results dictionary to accommodate post-processing.
  • Lighter version removes chains from results dictionary to keep json file a manageable size.
  • Methods added to ChainProcessing module for loading serial and parallel MCMC simulations. These methods load the results dictionary from json, then look to see if the chains are included. If not, then it searches for log files matching the specified extension. If none are found, then it returns an empty list for each type of chain.
  • This should help to address #55 .

prmiles added some commits Jun 15, 2019

added method to check whether chains included
- loads json results and checks in chains are included
- if not, then uses chain loading method
- if no chains found, displays warning message
added loading methods for serial and parallel simulations
- load_serial_simulation_results
- load_parallel_simulation_results -> original version is still in ParallelMCMC

@prmiles prmiles merged commit a9f563d into dev_1.8.0 Jun 15, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.565%
Details

@prmiles prmiles deleted the light-results branch Jun 15, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jun 15, 2019

Pull Request Test Coverage Report for Build 410

  • 60 of 72 (83.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 97.565%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pymcmcstat/MCMC.py 3 4 75.0%
pymcmcstat/structures/ResultsStructure.py 2 13 15.38%
Totals Coverage Status
Change from base Build 404: -0.4%
Covered Lines: 2324
Relevant Lines: 2382

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.