esp-usb-serial-jtag: Add write batching #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
esp-jtag-batching
branch
4 times, most recently
from
62e17f0 to
7f724fa
Compare
|
@Yatekii, any thoughts on this PR? |
Yatekii
reviewed
Jul 1, 2023
|
I like this a lot! Will do a proper review this weekend :) sorry it takes so long ... |
* Split single execution writes in `prepare_` and `recieve_` parts. * Add batched writes which runs `prepare` x times and batches results. * To facilitate batching, a `OwnedBitIter` struct was added to keep the bits around longer than a single write location.
MabezDev
force-pushed
the
esp-jtag-batching
branch
from
dd10c01 to
a74ab61
Compare
Yatekii
reviewed
Jul 4, 2023
Yatekii
reviewed
Jul 4, 2023
Yatekii
reviewed
Jul 4, 2023
Yatekii
reviewed
Jul 4, 2023
Yatekii
approved these changes
Jul 4, 2023
MabezDev
force-pushed
the
esp-jtag-batching
branch
from
3a5a107 to
5a79571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare_andrecieve_parts.preparex times and batches results.OwnedBitIterstruct was added to keep thebits around longer than a single write call.
JTAGAccess::write_register_batch.