Add repo metadata to default template #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug on the first time setup where even though the bot was working, I was getting a 500 error logged to the console:
{ HttpError at response.text.then.message (/Users/tcbyrd/workspaces/probot-tests/basic/node_modules/@octokit/rest/lib/request/request.js:72:19) at process.internalTickCallback (internal/process/next_tick.js:77:7) name: 'HttpError', code: 500, status: 'Internal Server Error'Looking up the error internally, it was caused by an abilities mismatch:
Turning on the repository metadata permission in my app fixed this. Since this a read only permission that doesn't leak private information, we should probably be enabling this for any app by default. Importantly, when you go to https://github.com/settings/apps/new, it defaults this to read-only and you have to explicitly disable it, so this change will make the template reflect that default.