From 3dcb058293ba3d8a363f9285081b2cda3274bb9c Mon Sep 17 00:00:00 2001 From: Gregor Martynus <39992+gr2m@users.noreply.github.com> Date: Tue, 30 Apr 2024 17:25:22 -0700 Subject: [PATCH] fix(probot): passes logger to webhooks (#2010) * test(probot): passes logger to webhooks * fix(probot): passes logger to webhooks --- src/octokit/get-webhooks.ts | 1 + test/probot.test.ts | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/src/octokit/get-webhooks.ts b/src/octokit/get-webhooks.ts index 818d35536b..04b60700a7 100644 --- a/src/octokit/get-webhooks.ts +++ b/src/octokit/get-webhooks.ts @@ -11,6 +11,7 @@ export function getWebhooks(state: State) { // > The context of the event that was triggered, including the payload and // helpers for extracting information can be passed to GitHub API calls const webhooks = new Webhooks({ + log: state.log, secret: state.webhooks.secret!, transform: webhookTransform.bind(null, state), }); diff --git a/test/probot.test.ts b/test/probot.test.ts index cc80985e99..a635c13b68 100644 --- a/test/probot.test.ts +++ b/test/probot.test.ts @@ -625,5 +625,21 @@ describe("Probot", () => { expect(error.message).toMatch(/error from app/); } }); + + it.only("passes logger to webhooks", async () => { + const probot = new Probot({ + appId, + privateKey, + log: pino(streamLogsToOutput), + }); + + // @ts-expect-error + probot.on("unknown-event", () => {}); + + expect(output.length).toEqual(1); + expect(output[0].msg).toEqual( + '"unknown-event" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)' + ); + }); }); });