Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not receiving `issue_comment` related events #933

Closed
phanirithvij opened this issue May 11, 2019 · 5 comments

Comments

@phanirithvij
Copy link

commented May 11, 2019

Bug Report / Feature request

Current Behavior
The events issue_comment.created or issue_comment.edited mentioned here in the github docs are not being logged.

// I'm using the wildcard * to log all events
app.on('*', async (context) => {
    context.log({ event: context.event, action: context.payload.action })
})

The events comment created or updated under an issue are not being logged.
The events new issue created, code pushed are being logged.

Expected behavior/code
There's supposed to be a webhook event emitted when there's a new comment under an issue

Environment

  • Probot version(s): 7.2.0
  • Node/npm version: v11.12.0/6.9.0
  • OS: Windows 10

Possible Solution

It's either implemented and I have some kind of problems with my probot configuration or it's not implemented. Please implement it if it's already not. Add a feature_request label to this issue.

Additional context/Screenshots
N/A

@welcome

This comment has been minimized.

Copy link

commented May 11, 2019

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@issue-label-bot issue-label-bot bot added the bug 🐞 label May 11, 2019

@issue-label-bot

This comment has been minimized.

Copy link

commented May 11, 2019

Issue-Label Bot is automatically applying the label bug 🐞 to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@wilhelmklopp

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@phanirithvij does your GitHub App have permission for issues and is subscribed to the issue_comment events?

image

image

You can check this in the GitHub App settings: https://github.com/settings/apps

GitHub
GitHub is where people build software. More than 36 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@gr2m gr2m added support and removed bug 🐞 labels May 13, 2019

@phanirithvij

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

@wilhelmklopp Thanks I understand that there are permissions now. But I think it was never mentioned in the docs as I followed the setup from the docs. Can you please update them mentioning this example that if a user wants to subscribe to issue_comment changes they first need to set up the permissions.

@stale

This comment has been minimized.

Copy link

commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 7, 2019

@stale stale bot closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.